Stylistic changes to spec files

ee/spec/lib/gitlab/usage_data_spec.rb

@@ -272,10 +272,7 @@
   end
 
   describe 'auto_issue_creation_projects' do
-    subject { described_class.data.dig(:counts, :projects_auto_issue_creation_enabled) }
-    let!(:project) { create(:project) }
-
-    RSpec.shared_context 'Prometheus alerts exist' do
+    shared_context 'Prometheus alerts exist' do
       before do
         environment = create(:environment, project: project)
         alert = create(:prometheus_alert, project: project, environment: environment)
@@ -283,6 +280,10 @@
       end
     end
 
+    let(:project) { create(:project) }
+
+    subject { described_class.data.dig(:counts, :projects_auto_issue_creation_enabled) }
+
     context 'when incident_management feature is available' do
       before do
         stub_licensed_features(incident_management: true)
@@ -302,7 +303,11 @@
 
       context 'with settings set' do
         before do
-          create(:project_incident_management_setting, project: project, create_issue: setting)
+          create(
+            :project_incident_management_setting,
+            project: project,
+            create_issue: setting
+          )
         end
 
         context 'with no alert events yet' do

ee/spec/models/project_spec.rb

@@ -64,33 +64,29 @@
     end
 
     describe '.with_incident_issue_creation_enabled' do
+      subject { described_class.with_incident_issue_creation_enabled.count }
+
       context 'no incident management settings' do
         it 'returns a project' do
-          project = create(:project)
           expect(described_class.with_incident_issue_creation_enabled).to include(project)
         end
       end
 
       context 'with incident management settings' do
         before do
-          project = create(:project)
           create(:project_incident_management_setting, project: project, create_issue: enabled)
         end
 
         context 'create_issue turned off' do
           let(:enabled) { false }
 
-          it 'does not return a project' do
-            expect(described_class.with_incident_issue_creation_enabled.count).to be 0
-          end
+          it { is_expected.to eq(0) }
         end
 
         context 'create_issue turned on' do
           let(:enabled) { true }
 
-          it 'returns a project' do
-            expect(described_class.with_incident_issue_creation_enabled.count).to be 1
-          end
+          it { is_expected.to eq(1) }
         end
       end
     end