Implement CreateApprovalEvent worker/service
This is a start of splitting approval side effects into smaller subscribers to `MergeRequests::ApprovedEvent`. The idea is to move each side effect into its own worker and ensure that it's idempotent as event store subscribers should be idempotent.
Showing
- app/services/merge_requests/after_approval_service.rb 0 additions, 44 deletionsapp/services/merge_requests/after_approval_service.rb
- app/services/merge_requests/approval_service.rb 34 additions, 7 deletionsapp/services/merge_requests/approval_service.rb
- app/services/merge_requests/create_approval_event_service.rb 11 additions, 0 deletionsapp/services/merge_requests/create_approval_event_service.rb
- app/workers/all_queues.yml 5 additions, 5 deletionsapp/workers/all_queues.yml
- app/workers/merge_requests/create_approval_event_worker.rb 2 additions, 5 deletionsapp/workers/merge_requests/create_approval_event_worker.rb
- config/sidekiq_queues.yml 2 additions, 2 deletionsconfig/sidekiq_queues.yml
- ee/app/services/ee/merge_requests/approval_service.rb 43 additions, 3 deletionsee/app/services/ee/merge_requests/approval_service.rb
- ee/app/services/ee/merge_requests/create_approval_event_service.rb 27 additions, 0 deletions...rvices/ee/merge_requests/create_approval_event_service.rb
- ee/spec/services/ee/merge_requests/create_approval_event_service_spec.rb 49 additions, 0 deletions...s/ee/merge_requests/create_approval_event_service_spec.rb
- ee/spec/services/merge_requests/approval_service_spec.rb 111 additions, 0 deletionsee/spec/services/merge_requests/approval_service_spec.rb
- lib/gitlab/event_store.rb 1 addition, 1 deletionlib/gitlab/event_store.rb
- spec/services/merge_requests/after_approval_service_spec.rb 0 additions, 60 deletionsspec/services/merge_requests/after_approval_service_spec.rb
- spec/services/merge_requests/approval_service_spec.rb 57 additions, 9 deletionsspec/services/merge_requests/approval_service_spec.rb
- spec/services/merge_requests/create_approval_event_service_spec.rb 22 additions, 0 deletions...ices/merge_requests/create_approval_event_service_spec.rb
- spec/workers/merge_requests/create_approval_event_worker_spec.rb 8 additions, 6 deletions...rkers/merge_requests/create_approval_event_worker_spec.rb
Please register or sign in to comment