Return inherited members of approval groups as approvers
Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/255981 **Problem** If the subgroup is an approval group, then indirect members of this group (direct members of parent group) don't show up as approvers. **Solution** Return group members not only from approval groups but also from their ancestors.
Showing
- config/feature_flags/development/use_inherited_permissions_for_approval_rules.yml 8 additions, 0 deletions...elopment/use_inherited_permissions_for_approval_rules.yml
- ee/app/models/concerns/approval_rule_like.rb 26 additions, 3 deletionsee/app/models/concerns/approval_rule_like.rb
- ee/spec/models/approval_merge_request_rule_spec.rb 1 addition, 1 deletionee/spec/models/approval_merge_request_rule_spec.rb
- ee/spec/models/concerns/approval_rule_like_spec.rb 53 additions, 20 deletionsee/spec/models/concerns/approval_rule_like_spec.rb
- ee/spec/presenters/approval_rule_presenter_spec.rb 1 addition, 1 deletionee/spec/presenters/approval_rule_presenter_spec.rb
- ee/spec/services/approval_rules/finalize_service_spec.rb 2 additions, 2 deletionsee/spec/services/approval_rules/finalize_service_spec.rb
Please register or sign in to comment