Tidy up merge_request_approvals_entity_spec.rb

spec/serializers/merge_request_approvals_entity_spec.rb

@@ -3,7 +3,7 @@
 describe MergeRequestApprovalsEntity do
   let(:project)  { create(:empty_project, approvals_before_merge: 2) }
   let(:user)     { create(:user) }
-  let(:other_user)     { create(:user) }
+  let(:other_user) { create(:user) }
   let(:resource) { create(:merge_request, source_project: project) }
   let(:request) { double('request', current_user: user) }
 
@@ -12,16 +12,18 @@
   before do
     project.add_master(user)
 
-    resource.approvals.create(user: user)
-    resource.approvers.create(user: other_user)
+    resource.approvals.create!(user: user)
+    resource.approvers.create!(user: other_user)
   end
 
   it 'exposes approvals properties' do
-    expect(entity[:approvals_required]).to eq(2)
-    expect(entity[:approvals_left]).to eq(1)
-    expect(entity[:approved_by].to_json).to eq([user: UserEntity.represent(user)].to_json)
-    expect(entity[:suggested_approvers].to_json).to eq([UserEntity.represent(other_user)].to_json)
-    expect(entity[:user_can_approve]).to eq(resource.can_approve?(user))
-    expect(entity[:user_has_approved]).to eq(resource.has_approved?(user))
+    is_expected.to eq(
+      approvals_required: 2,
+      approvals_left: 1,
+      approved_by: [{ user: UserEntity.represent(user).as_json }],
+      suggested_approvers: [UserEntity.represent(other_user).as_json],
+      user_can_approve: false,
+      user_has_approved: true
+    )
   end
 end